feat(connectors): cleanup life cycle without dispose #6497
+816
−2,558
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 713fb0c:
|
Haroenv
changed the title
dhayab
approved these changes
Dec 31, 2024
…pose In `dispose`, we no longer have any logic other than clearing listeners and removing rendering. This causes a significant simplification in all connectors. One side-effect of this is that `configure` no longer can be collaborating in ui state. If we'd want that, there's no way to distinguish between the ui state set for one configure or the one set for another. Therefore the configure widget is completely in charge of its parameters. If you want to synchronise configure with the URL, do that separately of the UI State. Small side-effect of this PR is the deduplication of the test/mock createWidget files BREAKING CHANGE: widgets no longer explicitly clean in dispose (handled in index widget automatically) BREAKING CHANGE: configure no longer shows in ui state or routing. [FX-3209]
Haroenv
force-pushed
the
feat/simplify-dispose
branch
from
fff286e to
713fb0c
Compare
|
Thanks, the e2e test doesn't really deal with adding and removing widgets though, so it makes sense it has no impact |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In
dispose, we no longer have any logic other than clearing listeners and removing rendering. This causes a significant simplification in all connectors.One side-effect of this is that
configureno longer can be collaborating in ui state. If we'd want that, there's no way to distinguish between the ui state set for one configure or the one set for another. Therefore the configure widget is completely in charge of its parameters. If you want to synchronise configure with the URL, do that separately of the UI State.Small side-effect of this PR is the deduplication of the test/mock createWidget files
BREAKING CHANGE: widgets no longer explicitly clean in dispose (handled in index widget automatically)
BREAKING CHANGE: configure no longer shows in ui state or routing.
FX-3209