Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimize PageMap Iterator #329

Merged
merged 2 commits into from
Nov 18, 2024
Merged

Optimize PageMap Iterator #329

merged 2 commits into from
Nov 18, 2024

Conversation

abdelmagied94
Copy link
Contributor

Summary

This PR addresses this concern by updating the PageMap iterator logic to prevent unnecessary copying of page items, enhancing overall performance.

Result

  • Performance tuning for PageMap iteration
  • Project still compiles successfully in Xcode 16

@abdelmagied94 abdelmagied94 mentioned this pull request Nov 2, 2024
Merged
@abdelmagied94
Copy link
Contributor Author

@Haroenv @aallam Could you please take a look?

@Haroenv Haroenv requested a review from aallam November 8, 2024 13:53
@dhayab dhayab merged commit d3eff80 into algolia:master Nov 18, 2024
7 of 10 checks passed
@dhayab
Copy link
Member

dhayab commented Nov 18, 2024

The pipeline fails as we don't allow secrets to be passed to pipelines from forks, but everything checks out locally. Thanks for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aallam aallam aallam approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@abdelmagied94 @dhayab @aallam