Skip to content

fix: call onClose when askAi is active #2810

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
+2 −0
Closed

fix: call onClose when askAi is active #2810

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions packages/docsearch-core/src/useDocSearchKeyboardEvents.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,7 @@ export function useDocSearchKeyboardEvents({
function onKeyDown(event: KeyboardEvent): void {
if (isOpen && event.code === 'Escape' && isAskAiActive) {
onAskAiToggle(false);
onClose();
Copy link
Contributor

@8bittitan 8bittitan Dec 2, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't believe these are the correct places for this. This block is meant to "leave" the Ask AI experience and go back to the keyword search experience, without closing the modal.

I believe the issue is more that the cleanup of this useEffect is not getting ran, causing the keydown event listener to never get removed.

The root issue for the modal opening again is that we focus the search button on close, and then have a listener that opens the modal again on keypress if the search button is the focused element.

return;
}

Expand Down
1 change: 1 addition & 0 deletions packages/docsearch-react/src/useDocSearchKeyboardEvents.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,7 @@ export function useDocSearchKeyboardEvents({
function onKeyDown(event: KeyboardEvent): void {
if (isOpen && event.code === 'Escape' && isAskAiActive) {
onAskAiToggle(false);
onClose();
return;
}

Expand Down