fix(javascript): Added warning in comment #5961
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
✔️ Code generated!
📊 Benchmark resultsBenchmarks performed on the method using a mock server, the results might not reflect the real-world performance.
|
Fluf22
reviewed
Feb 12, 2026
Comment on lines
+112
to
+115
| * Make sure to use a non-serializing cache implementation, such as: | ||
| * | ||
| * - `createMemoryCache({ serializable: false })` | ||
| * - `createNullCache()` |
Collaborator
There was a problem hiding this comment.
More precisely, createNullCache() is not a non-serializing cache 😄
But it's a good option, so maybe something like:
Suggested change
| * Make sure to use a non-serializing cache implementation, such as: | |
| * | |
| * - `createMemoryCache({ serializable: false })` | |
| * - `createNullCache()` | |
| * Make sure to use a non-serializing cache implementation, such as `createMemoryCache({ serializable: false })` or to disable request caching with `createNullCache()` |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🧭 What and Why
🎟 JIRA Ticket: API-300
Changes included: