Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(dart): fix DioRequester.requestUri when HttpRequest.queryParameters is not empty #3349

Open
wants to merge 26 commits into
base: main
Choose a base branch
from
Open
Changes from all commits
Commits
Show all changes
26 commits
Select commit Hold shift + click to select a range
814138e
fix(dart): fix DioRequester.requestUri
techouse Jul 10, 2024
9f4f5cb
Merge branch 'main' into fix/dio-requester-requestUri
techouse Jul 11, 2024
c758b9e
Merge branch 'main' into fix/dio-requester-requestUri
techouse Jul 16, 2024
74774f7
Merge branch 'main' into fix/dio-requester-requestUri
techouse Jul 17, 2024
32e3895
Merge branch 'main' into fix/dio-requester-requestUri
techouse Jul 19, 2024
7146c7f
Merge branch 'main' into fix/dio-requester-requestUri
techouse Jul 28, 2024
a0ef2c3
Merge branch 'main' into fix/dio-requester-requestUri
techouse Jul 30, 2024
c2a2151
Merge branch 'main' into fix/dio-requester-requestUri
techouse Jul 30, 2024
33c2c2d
Merge branch 'main' into fix/dio-requester-requestUri
techouse Aug 5, 2024
ba634c1
Merge branch 'main' into fix/dio-requester-requestUri
techouse Aug 23, 2024
9491108
Merge branch 'main' into fix/dio-requester-requestUri
techouse Aug 27, 2024
f065590
Merge branch 'main' into fix/dio-requester-requestUri
techouse Sep 9, 2024
b683e34
Merge branch 'main' into fix/dio-requester-requestUri
techouse Oct 2, 2024
2790ddc
Merge branch 'main' into fix/dio-requester-requestUri
techouse Oct 24, 2024
09fe892
Merge branch 'main' into fix/dio-requester-requestUri
techouse Nov 5, 2024
855bece
Merge branch 'main' into fix/dio-requester-requestUri
techouse Nov 14, 2024
7f5a9ff
Merge branch 'main' into fix/dio-requester-requestUri
techouse Nov 15, 2024
ca4a498
Merge branch 'main' into fix/dio-requester-requestUri
techouse Nov 15, 2024
676bf7d
Merge branch 'main' into fix/dio-requester-requestUri
techouse Nov 15, 2024
1b7ae1a
Merge branch 'main' into fix/dio-requester-requestUri
techouse Nov 18, 2024
a60420b
Merge branch 'main' into fix/dio-requester-requestUri
techouse Nov 19, 2024
104d077
Merge branch 'main' into fix/dio-requester-requestUri
techouse Nov 20, 2024
7ccb49e
Merge branch 'main' into fix/dio-requester-requestUri
techouse Nov 22, 2024
286cb4f
Merge branch 'main' into fix/dio-requester-requestUri
techouse Nov 27, 2024
64d887f
Merge branch 'main' into fix/dio-requester-requestUri
techouse Dec 16, 2024
8c1852a
Merge branch 'main' into fix/dio-requester-requestUri
techouse Dec 20, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -99,20 +99,17 @@ class DioRequester implements Requester {
}

/// Constructs the request URI from the [request] details.
Uri requestUri(HttpRequest request) {
Uri uri = Uri(
scheme: request.host.scheme,
host: request.host.url,
port: request.host.port,
path: request.path,
);
if (request.queryParameters.isNotEmpty) {
return Uri.dataFromString(
"${uri.toString()}?${request.queryParameters.entries.map((e) => "${e.key}=${e.value}").join("&")}");
}

return uri;
}
Uri requestUri(HttpRequest request) => Uri(
scheme: request.host.scheme,
host: request.host.url,
port: request.host.port,
path: request.path,
query: request.queryParameters.isNotEmpty
? request.queryParameters.entries
.map((e) => "${e.key}=${e.value}")
.join("&")
: null,
);

@override
void close() => _client.close();
Expand Down
Loading