-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(CTS): benchmark the search method #3328
Conversation
✔️ Code generated!
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
wonderful idea
generators/src/main/java/com/algolia/codegen/cts/tests/TestsClient.java
Outdated
Show resolved
Hide resolved
@@ -0,0 +1,35 @@ | |||
[ | |||
{ | |||
"testName": "benchmark the search method", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thinking of it, this in fact benchmarks any method of the search client, no? do we expect different outcomes?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes we could test anything, I just picked the search endpoint because it does body serialization and has a lot of props in the body
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nothing to add, it looks really nice!!
once we are confident with our testserver implems we should make sure our contributing guide is super complete, just for the sake of maintenance and other contributors, because it keeps growing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oops good catch
🧭 What and Why
Benchmark some methods using the mock server
You can run the benchmarks with
apic cts run -vbrec