Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(CTS): benchmark the search method #3328

Merged
merged 23 commits into from
Jul 22, 2024
Merged

chore(CTS): benchmark the search method #3328

merged 23 commits into from
Jul 22, 2024

Conversation

millotp
Copy link
Collaborator

@millotp millotp commented Jul 8, 2024

🧭 What and Why

Benchmark some methods using the mock server

You can run the benchmarks with apic cts run -vbrec

@millotp millotp self-assigned this Jul 8, 2024
@algolia-bot
Copy link
Collaborator

algolia-bot commented Jul 8, 2024

✔️ Code generated!

Name Link
🪓 Triggered by 766b790258a3c16b01f1fb011afced10978352d3
🍃 Generated commit 53d2e05036ac5d6b53662c51fd7c8ac37bacf8b2
🌲 Generated branch generated/chore/benchmark

Copy link

github-actions bot commented Jul 12, 2024

@millotp millotp marked this pull request as ready for review July 21, 2024 20:00
@millotp millotp requested a review from a team as a code owner July 21, 2024 20:00
Copy link
Member

@shortcuts shortcuts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wonderful idea

specs/search/helpers/README.md Outdated Show resolved Hide resolved
@@ -0,0 +1,35 @@
[
{
"testName": "benchmark the search method",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thinking of it, this in fact benchmarks any method of the search client, no? do we expect different outcomes?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes we could test anything, I just picked the search endpoint because it does body serialization and has a lot of props in the body

shortcuts
shortcuts previously approved these changes Jul 22, 2024
Copy link
Member

@shortcuts shortcuts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nothing to add, it looks really nice!!

once we are confident with our testserver implems we should make sure our contributing guide is super complete, just for the sake of maintenance and other contributors, because it keeps growing

shortcuts
shortcuts previously approved these changes Jul 22, 2024
Copy link
Member

@shortcuts shortcuts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oops good catch

@millotp millotp enabled auto-merge (squash) July 22, 2024 12:26
@millotp millotp merged commit 23fd55c into main Jul 22, 2024
21 checks passed
@millotp millotp deleted the chore/benchmark branch July 22, 2024 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants