-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(dart): add Dio HttpClientAdapter to ClientOptions #3290
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks awesome, thanks a lot for the contribution
@aallam wdyt?
Not sure why the codegen job fails 馃槄 |
ah we provide a ref to the checkout action which might not work with forks D: |
Ah, makes sense. Bots and their permissions 馃檲 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! we already have interceptors, and I see no issue of adding HttpClientAdapter
too.
All CTS should fail because of e2e, I'll open a PR with your commits and merge them into main |
ah nvm there's no e2e for dart, all good then |
(i'll co author you obviously) |
Roger that 馃 |
馃Л What and Why
This PR gives the user the ability to optionally provide a custom Dio
HttpClientAdapter
, i.e.Via this option users can configure Dio to use native_dio_adapter which uses cupertino_http on iOS and cronet_http on Android to delegate HTTP requests to the native platform instead of the
dart:io
platforms.The advantages of using cronet_http are:
The advantages of using cupertino_http are:
Changes included:
HttpClientAdapter?
toClientOptions
Supersedes algolia/algoliasearch-client-dart#13
Addresses algolia/algoliasearch-client-dart#12