Develop (#1155)

algolia · Feb 17, 2020 · a71c815 · a71c815
1 parent 0b7145a
commit a71c815
Show file tree

Hide file tree

Showing 9 changed files with 19 additions and 10 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,5 +1,14 @@
 # CHANGE LOG
 
+## 1.17.1
+
+### Updates
+- Clean up and condition the analytics url (#1149) 
+- Remove IS enable condition for empty result popular queries (#1151) 
+
+### Fixes
+- Remove (un)serialize methods to pass new Marketplace expectations (#1152) 
+
 ## 1.17.0
 
 ### Updates

diff --git a/README.md b/README.md
@@ -1,7 +1,7 @@
 Algolia Search for Magento 1.6+
 ==================
 
-![Latest version](https://img.shields.io/badge/latest-1.17.0-green.svg)
+![Latest version](https://img.shields.io/badge/latest-1.17.1-green.svg)
 
 [![Build Status](https://travis-ci.org/algolia/algoliasearch-magento.svg?branch=master)](https://travis-ci.org/algolia/algoliasearch-magento)
 ![PHP >= 5.3](https://img.shields.io/badge/php-%3E=5.3-green.svg)

diff --git a/app/code/community/Algolia/Algoliasearch/Helper/Config.php b/app/code/community/Algolia/Algoliasearch/Helper/Config.php
@@ -618,7 +618,7 @@ public function getCurrency($storeId = null)
 
     public function getPopularQueries($storeId = null)
     {
-        if (!$this->isInstantEnabled($storeId) || !$this->showSuggestionsOnNoResultsPage($storeId)) {
+        if (!$this->showSuggestionsOnNoResultsPage($storeId)) {
             return array();
         }
 

diff --git a/app/code/community/Algolia/Algoliasearch/etc/config.xml b/app/code/community/Algolia/Algoliasearch/etc/config.xml
@@ -2,7 +2,7 @@
 <config>
     <modules>
         <Algolia_Algoliasearch>
-            <version>1.17.0</version>
+            <version>1.17.1</version>
         </Algolia_Algoliasearch>
     </modules>
     <frontend>

diff --git a/app/code/community/Algolia/Algoliasearch/etc/system.xml b/app/code/community/Algolia/Algoliasearch/etc/system.xml
@@ -4,7 +4,7 @@
         <algoliasearch translate="label" module="algoliasearch">
             <label>
                 <![CDATA[
-                Algolia Search 1.17.0
+                Algolia Search 1.17.1
                 <style>
                     .algoliasearch-admin-menu span {
                         padding-left: 38px !important;

diff --git a/app/design/frontend/base/default/template/algoliasearch/internals/configuration.phtml b/app/design/frontend/base/default/template/algoliasearch/internals/configuration.phtml
@@ -263,6 +263,7 @@ $algoliaJsConfig = array(
     'maxValuesPerFacet' => (int) $config->getMaxValuesPerFacet(),
     'autofocus' => true,
     'ccAnalytics' => array(
+        'enabled' => $config->isClickConversionAnalyticsEnabled(),
         'ISSelector' => $config->getClickConversionAnalyticsISSelector(),
         'conversionAnalyticsMode' => $config->getConversionAnalyticsMode(),
         'addToCartSelector' => $config->getConversionAnalyticsAddToCartSelector(),

diff --git a/app/etc/modules/Algolia_Algoliasearch.xml b/app/etc/modules/Algolia_Algoliasearch.xml
@@ -4,7 +4,7 @@
         <Algolia_Algoliasearch>
             <active>true</active>
             <codePool>community</codePool>
-            <version>1.17.0</version>
+            <version>1.17.1</version>
         </Algolia_Algoliasearch>
     </modules>
 </config>
diff --git a/js/algoliasearch/click_conversion_analytics.js b/js/algoliasearch/click_conversion_analytics.js
@@ -79,11 +79,6 @@ algolia.registerHook('beforeInstantsearchStart', function (search) {
 	return search;
 });
 
-algolia.registerHook('beforeWidgetInitialization', function (allWidgetConfiguration) {
-	allWidgetConfiguration['hits']
-	return allWidgetConfiguration;
-});
-
 algolia.registerHook('beforeInstantsearchInit', function (instantsearchOptions) {
 	instantsearchOptions.searchParameters['clickAnalytics'] = true;
 	return instantsearchOptions;

diff --git a/js/algoliasearch/instantsearch.js b/js/algoliasearch/instantsearch.js
@@ -2,6 +2,10 @@ document.addEventListener("DOMContentLoaded", function (event) {
 	algoliaBundle.$(function ($) {
 
 		function makeUrlForInsights(baseUrl, objectID, queryID, indexName) {
+			if (algoliaConfig.ccAnalytics.enabled !== true) {
+				return baseUrl;
+			}
+
 			var _baseUrl = baseUrl.indexOf('?') === -1 ? baseUrl + '?' : baseUrl;
 			return _baseUrl + $.param({
 				queryID: queryID,