Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added exception handling and length of key check #54

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

LydiaNtafa
Copy link

@LydiaNtafa LydiaNtafa commented Apr 11, 2024

Contributing to Algolia Samples

All third-party contributors acknowledge that any contributions they provide will be made under the same open-source license that the open-source project is provided under.

  • I acknowledge that all my contributions will be made under the project's license.

@matthewbond matthewbond self-requested a review April 18, 2024 08:07
php/generate_key.php Outdated Show resolved Hide resolved
php/generate_key.php Outdated Show resolved Hide resolved
try {
# Test the new generated key by performing a search
if ($search_res = $index->search('')) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we also check the search returned a result?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point! I'll add that and update the PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants