Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Dz Code Academy and fixed a typo #5

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

ilyeshammadi
Copy link

No description provided.

Copy link
Member

@IOAyman IOAyman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.


## Other
- [Deniable Encrypted Keys Database](https://github.com/abderraouf-adjal/dekdb-format-specifications) - Deniable Encrypted Keys Database (DEKDB) format specifications
- [Tamazight Keyboard Layout](https://github.com/noureddineme/tamazight-layout) - Linux tamazight keyboard layout (bouth Tifinagh and Latin)
- [DZ Code Academy](https://github.com/Ilyes-Hammadi/dz-code-academy) - Learn to code in Arabic (Algerian dialect)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like an empty repo pointing to a YouTube channel and missing a license.
Why not link the channel directly in a new Educational Material section, or something like that?

PS: Correct me if I am wrong, but this repo will contain some course material, right? If so, then I don't think it should be included at all.

Last but not least, I do love the work you've done over at that channel! 😉

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@IOAyman Thanks for the kind words. Yeah you are right i am gonna replace the link to the empty repo by including the youtube channel link in a new section like you suggested, i like the one you proposed.

@youknowriad
Copy link
Member

youknowriad commented Jan 10, 2017

Thanks for the PR. I'm not sure how I feel about this, These videos are awesome but it's not really a repository. Thus, this does not match the requirements and this list is not made for this kind of things.

@youknowriad
Copy link
Member

BTW, If you could extract the typo fixo in a separate PR, I'd be happy to merge it

@ilyeshammadi
Copy link
Author

Okey, I totally understand. I am gonna extract the typo changes into a separate PR.

@IOAyman
Copy link
Member

IOAyman commented Jan 10, 2017

@youknowriad, I've also thought about that point, but then I said to myself "I've seen other awesome-* lists containing links to various great courses and books on different platforms .. So why not this one".

@youknowriad
Copy link
Member

Yeah, I'm really hesitant here. Let's keep this PR open for a while. Maybe if we notice more similar projects, we could create a dedicated section or even a dedicated file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants