[WIP] Port to cabal-helper-1.0 (git) #33
Conversation
| let currentPackageId = HCE.PackageId (T.pack packageName) packageVersion | ||
| cabalHelperQueryEnv <- liftIO $ mkQueryEnv (ProjLocV1Dir packageDirectoryAbsPath) (DistDirV1 distDir) | ||
| ("ghc", packageGhcVersion) <- liftIO $ runQuery compilerVersion cabalHelperQueryEnv | ||
| unless (take 2 (versionBranch packageGhcVersion) == take 2 (versionBranch ghcVersion)) $ |
There was a problem hiding this comment.
@alexwl did you think about this? AFAIR GHC can break hi-file format compatibility even with just a minor version bump. So really the versions would have to match exactly.
There was a problem hiding this comment.
It seem that the version of GHC from the header of setup-config contains only two numbers - major and minor (showHeader function from Cabal uses compilerVersion from System.Info: http://hackage.haskell.org/package/base-4.12.0.0/docs/src/System.Info.html#compilerVersion).
There was a problem hiding this comment.
Ah damn, I totally forgot we only get two version components in the header. That won't do at all then, I'll have to revert that compilerVersion optimization then. I think there's just no way around actually going through the helper to get the GHC version in that case.
Honestly that shouldn't be too big a deal though since that will only happen once per Cabal version, regardless of which GHC version is compiling the helper. So the error will take a while longer to pop up but when the user gets to re-trying with a different GHC the helper will already be ready.
There was a problem hiding this comment.
OH! Even worse if the header version is from System.Info like you say then this is the GHC version that compiled Setup.hs and not the one Setup.hs decided to use to build the package! Yikes, that's just completely wrong then.
There was a problem hiding this comment.
Does it mean that the correct version of GHC should always be taken from LocalBuildInfo, not from the header of setup-config?
|
Thank you Daniel! It would be great to use the new version of I guess I should think about how to index multiple packages at once: haskell-code-explorer/src/HaskellCodeExplorer/PackageInfo.hs Lines 162 to 164 in 63ad1f6 Also, thank you for the fixed |
|
Yeah, indexing multiple packages would also make things easier for users because you can just let the indexer loose on a whole cabal/stack project rather than just one package :) |
I'm working on fleshing out the cabal-helper-1.0 API, figured I should see how bad I broke things using the old API so I decided to give porting this project a go. I had to tweak a few things but not too bad overall.
I also fixed
compileVersionbeing too slow (see the discussion here). It only depends on thesetup-configheader for V1 projects now.