-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Performance: attempt to optimize the ArrayHitCounter by maintaining some state while updating the counter #721
Draft
alexklibisz
wants to merge
17
commits into
main
Choose a base branch
from
160-optimize-hit-counter
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ents it needs to iterate over
…ack the min doc IDs
alexklibisz
changed the title
Performance: optimize the hit counter by limiting the number of documents it needs to iterate over
Performance: attempt to optimize the hit counter by limiting the number of documents it needs to iterate over
Aug 29, 2024
…stiknn into 160-optimize-hit-counter
…stiknn into 160-optimize-hit-counter
alexklibisz
changed the title
Performance: attempt to optimize the hit counter by limiting the number of documents it needs to iterate over
Performance: attempt to optimize the ArrayHitCounter by maintaining some state while updating the counter
Aug 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue
#160, #611
Changes
I had two ideas to speed up the ArrayHitCouner here, but they don't seem to be panning out in the benchmarks:
Testing and Validation
How was it validated?