Performance: optimize MatchHashesAndScoreQuery for case where a hash occurs once (96% recall at 190 qps) #612
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexklibisz
changed the title
alexklibisz
changed the title
alexklibisz
changed the title
…nn into optimize-single-freq
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue
#611
Changes
There is one LSH model (PermutationLsh) which can emit the same hash multiple times. Because of this, MatchHashesAndScoreQuery has to account for the fact that the same hash can occur multiple times. Through some trial and error, I figured out that this actually has a measurable impact on performance.
So this PR adds an optimized case to MatchHashesAndScoreQuery for hashes that occur once.
This gets the 96% recall up to 190 qps, only 10 qps away from the goal of #611.
(One of the benchmarks was as high as 195 qps, but I decided to advertise the lower value)
Testing and Validation
Standard CI and benchmarking