-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tripletloss, TripletCNN and further Tensorflow 2 support #2
Open
verrannt
wants to merge
21
commits into
alexhernandezgarcia:master
Choose a base branch
from
verrannt:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
del_mse_nodes() fails with TF2. This functionality should achieve the same end.
This is no guarantee that everything will work with TF2
triplet loss can be switched on or off with command line arguments
add shell script collecting invariance scores of different models for certain epochs
add shell script to collect test scores for specified models and epochs
add shell script to train the tripletcnn architecture as classifier without triplet loss on Cifar10
alexhernandezgarcia
previously approved these changes
Nov 4, 2020
edit paths for more generality
Comment on lines
-132
to
+137
# Ensure the model has no MSE nodes and outputs | ||
model = del_mse_nodes(model) | ||
# Ensure the model has no MSE nodes and outputs by building a new model | ||
# with the old models weights and only the softmax output | ||
softmax_layers = [layer for layer in model.layers if layer.name=='softmax'] | ||
assert len(softmax_layers) == 1, 'Model has multiple softmax layers' | ||
softmax_layer = softmax_layers[0] | ||
model = Model(model.input, softmax_layer.output) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a partial fix, since it may not work with models with more complex connectivity.
In any case these lines should go on surgery.py
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Amongst others, this pull request adds