add GlyphSvg #100
Merged
add GlyphSvg #100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! This looks quite reasonable to me. Nice one for making it non-breaking. I'll find some time soon to properly review soon. |
alexheretic
reviewed
Apr 9, 2024
Co-authored-by: Alex Butler <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a minimal addition of GlyphSvg to ab_glyph. The data is transferred as-is from ttfp without rendering or scaling or interpreting, as a minimally useful product.
I would rather render the SVG into a raster image somehow ti make it easier for callers but I don't want to add a dependency. (And I am not quite sure the work I did for the font I was using would apply to all fonts.)
I am rendering the SVG as needed here: https://github.com/asibahi/noor/blob/01ce89e01d8814763c1ebc1047ccad6f1c1c30fa/src/main.rs#L169 .