Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to set FedEx packaging when using OneRate #55

Conversation

khnbb
Copy link
Contributor

@khnbb khnbb commented Oct 4, 2023

FedEx packaging options can affect the rates returned when specifying OneRate, rather than using YOUR_PACKAGING.

  • Add override setting in ShipmentOptions
  • Check override setting and apply when OneRate is specified

@khnbb
Copy link
Contributor Author

khnbb commented Oct 4, 2023

Hi @alexeybusygin @creinker @oztrkkaan. I found a need to be able to specify using FedEx packaging when requesting OneRate rates, so after figuring out where that was in the repo, I created a possible solution, which is here in this pull request. Let me know what you think and thank you for your work on this repo!

@alexeybusygin alexeybusygin merged commit 50dfc9d into alexeybusygin:master Oct 21, 2023
@alexeybusygin
Copy link
Owner

Thank you for your contribution, Kurt! Released in v1.1.10

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants