-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
no responsive image is generated #13
Comments
I guess the actual image width is smaller than the one you want to generate. Then it doesn't make sense processing an image. It's possible to downscale an image, but you can't properly upscale it. Please have a look at the image width. |
It still does not work, I updated to TYPO3 7.6.9 and fluid_styled_responsive_images V1.2.0. The images aren’t rendered in the code:
|
If that is the output of my extension, that it worked well. You have all srcset entries, as defined in the configuration. If an image is big enough and you define smaller image widths, then the extension simply calls a core process with these params, so it processes the file. Did you check that imagemagick/graphicsmagick is properly installed and configured in your installation? |
Sorry, I don’t get it. It does not work in my opinion, the large image is not processed to its smaller variants, only the original file is referenced in all parts of the srcset-attribute. I just checked the image processing in the install tool, there is no problem with: You can get access to my sandbox to check it, I would be pleased. |
I believe you. That's not the issue here. I simply can't reproduce it in my environment and I didn't have such issues when I used this extension in production. What I'd need to solve this, is a reliable and reproducible case where I can debug the problem with xdebug. Because, what my extension really just does, is calling the core processing method with an image width. You are not the first and not the only one with this issue, so I guess there is a bug somewhere, but currently I don't see what I can do about it. What you could do: Is that issue depending on the GFX settings of TYPO3? Maybe you have both imagemagick and graphicsmagick and can test if just one of these fail. However, please let me know:
And last but nor least, please upload the exact failing image. Then I can try to reproduce that locally and find a fix for that issue. |
I tried the following images with the same problem: TYPO3 CMS 7.6.9
I can’t switch the graphics library because this is a shared hosting package. Operating system: Unix Apache/2.2.22
|
thx, will try it this weekend. |
I finally found a case where you get this exact html code: It always happens, when processed images cannot be created or written. Please check that files can be created in |
Forget about that comment. Just saw that you have images in the If you look at this line (https://github.com/alexanderschnitzler/fluid-styled-responsive-images/blob/master/Classes/Resource/Rendering/ImageRenderer.php#L192) you will see that the original image is processed and returns a
|
I’m sorry, I’m not an extension developer. I don’t know how to check that. |
Then I don't know how to help you any further. Sorry. |
Maybe you can give me some hint or code snippet that I can place inside the code to dump objects or variables for debugging. Thx. Other guess: Do you have the extension ws_textmedia_bootstrap with it’s static template activated? |
Can't you find someone who can shortly check all that for you? Just looking at the database and inserting the mentioned php snippet. PS: I don't have that extension installed. |
The extension is just a thin wrapper, provides some base configuration for fluid styled responsive images and passes everything to the f:media ViewHelper. You should be able to verify an assumption that there's something fishy with ws_texmedia_bootstrap by simply disabling the extension. |
@cedricziel THX, I’m pretty much aware of interferencing extensions and how to avoid that. I tested the following: I uploaded a new pic (4608 x 3456px) and created an new content element type text & media and inserted the new image. The original image is placed at: The rendered HTML code:
TYPO3 added the following five entries to the table sys_file_processedfile: Dumping the following,
I got:
HTH Karionis |
Thanks for the info. It really helps a lot. First of all I don't think that the screenshot shows the right processed images. It looks more like entries, created from the backend. But it's not a problem as I already see the actual issue.
|
That’s probably because I commented the width settings:
I did that because there’s no rendering of responsive images in the image tag at all when setting (uncommenting) the widths:
In this case the var_dump command isn’t even executed… |
Don't get me wrong but this consumes a lot of time and now finding out that I am searching for an error at the completely wrong place while you simply commented out the width definition really makes me angry. For sure a width definition is needed. Why didn't you tell me so? Now, we start from scratch... As this gets more and more time consuming it would be best if you (temporarily) gave me access to the server where you experience that bug. Meanwhile you can also use the latest version in |
Dont’ get me wrong, but
Take me serious. Thanks. I’ll try to get the developer version and provide you access. Karionis |
Yes, you described both scenarios but who would think we are talking about the case where you leave out the image widths? How would you scale images if no image width is given? Isn't it logical that this case cannot work anyway? Whatever... It might sound strange but I will need ssh access, so I can debug the codebase on the server. I can give you my public key, so you can easily remove access afterwards. Is that manageable? |
Found the root of all evil! Before the responsive images are created the I recommend setting these highlighted values to a very high number, like 6000. |
This ticket is kind of a duplicate for #8 |
Nice! Many thanks! Hmm, those settings should be mentionied in the documentation or will that be part of the static template of the next version? Cheers Karionis |
Problem is, that this is not my setting. And that GalleryProcessor is a core thing which processes images before this extension renders all other versions. I am thinking about that for a while now and I guess the best solution is to not rely on the given image but use the physical image width instead and make all that an option. |
I see the difficulties now, why is there no support for responsive images like version 6.2.x which can be easily selected in the constants editor? Is it planned? |
The reason is that you use fluid_styled_content instead of css_styled_content and people didn't think of responsive images. There has been a code sprint lately, so maybe there will be something in the core some day. For now you need an extension unfortunately. |
I don't think that there will be an extension like that in < 7.4 and i think that using the real image dimensions is not the best option, because then you have no real control of the generated results. For example: if there is an image with the width of 6000 pixel, TYPO3 will always process ALL images defined in your srcset, regardless of what TYPO3 (or any other extensions which extend or replace the GalleryProcessor) choose as possible maximum width. But you are right: there is definitly a need of responsive image handling in TYPO3! |
Hello,
it doesn't work (fluid_styled_responsive_images Version 1.1.1).
I've included the follwing static templates:
Content Elements (fluid_styled_content)
Content Elements CSS (optional) (fluid_styled_content)
Fluid Styled Responsive Images (fluid_styled_responsive_images)
into my TYPO3 7.6.6.
TypoScript-Setup:
No image is rendered to the srcset-attribute in the textmedia-elemtent:
If I set the width-settings to a comment,:
I get the following img-tag with srcset-attribute, but again no scaled image is generated:
The text was updated successfully, but these errors were encountered: