Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

What i am missing? #12

Closed
timofo opened this issue Apr 14, 2016 · 2 comments
Closed

What i am missing? #12

timofo opened this issue Apr 14, 2016 · 2 comments
Milestone

Comments

@timofo
Copy link

timofo commented Apr 14, 2016

i have installed the extension and included the static template after fluid styled content.

tt_content.textmedia.settings.responsive_image_rendering.sourceCollection { medium { width = 720m srcset = 720w sizes = 100vw } large { width = 940m srcset = 940w sizes = 100vw } bigger { width = 1140m srcset = 1140w sizes = 100vw } }
this is my testcode. But my images are missing the srcset attribute?
I am missing something?

edit:
if i make a var_dump of $this in function buildImageTag then i see that srcset is empty. But you can see my typoscript. srcset ist set.

if i write a throw exception instead of continue in processSourceCollection, then i get a:
RuntimeException thrown in file
ext/fluid_styled_responsive_images/Classes/Resource/Rendering/ImageRenderer.php in line 191.
if ((int)$sourceCollection['width'] > (int)$this->defaultWidth) {

What does it mean?
How is the width (default width) calculated?

only works if i set
styles.content.textmedia.maxW = 10000 styles.content.textmedia.maxWInText = 10000

@alexanderschnitzler
Copy link
Owner

This seems to be the same issue like in #13.

I guess the actual image width is smaller than the one you want to generate. Then it doesn't make sense processing an image. It's possible to downscale an image, but you can't properly upscale it.

Please have a look at the image width.

@alexanderschnitzler alexanderschnitzler added this to the 1.3.0 milestone Jun 13, 2016
@alexanderschnitzler
Copy link
Owner

If this ticket is still relevant, feel free to reopen.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants