Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2024.1 compatibility #16

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Conversation

ludovicmeurot
Copy link

Hi Alexander,

A simple update to make the plugin compatible with the latest version.

Thank you for this plugin!

@AlejandroBudy
Copy link

Are there any plans to merge this pr?

@wojciech-zurek
Copy link

@ludovicmeurot Can you temporarily share this plugin?

@jordanbrock
Copy link

please merge this PR

@kimsunhak
Copy link

@alexadhy Other users are waiting for PR to merge. When do you plan to do it?

@djhoese
Copy link

djhoese commented Jun 3, 2024

For those unfamiliar with plugin compilation from source, if I clone this fork locally, how could I build it and install it?

@wojciech-zurek
Copy link

@djhoese

Ediit gradle.properties (0.1.6 is already in market)

pluginVersion = 0.1.7

then use docker in plugin directory:

docker run --rm -u gradle -v "$PWD":/home/gradle/project -w /home/gradle/project gradle:8.0.2-jdk11 gradle buildPlugin

The path for built plugin: build/distributions/TokyoNight Theme-0.1.7.zip

In your ide go to plugin list and use option: "Install plugin from disk"

@djhoese
Copy link

djhoese commented Jun 3, 2024

Awesome! Got it working. Thanks!

<!-- Plugin description -->

Fork of https://github.com/alexadhy/tokyonight-jetbrains
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This probably needs to be removed if you want this merged eventually, right?

@juliogc
Copy link

juliogc commented Jun 4, 2024

Hello, everyone,

It is safe to say that the repository's owner doesn't care about updating it based on what we are experiencing here and from what I've found in the repository's history. The fix for versions 2023.x has been open for almost a year, and this change request is going in the same direction.

Since I don't want to spend a year begging for this, I recommend using alternatives to this extension.

Looking at the marketplace, I found a forked version that only supports the dark version: https://github.com/junkfactory/tokyonight-jetbrains

You can install it here: https://plugins.jetbrains.com/plugin/24455-tokyo-dark-theme

@zeekbyte
Copy link

zeekbyte commented Sep 13, 2024

Hi everyone. After waiting without any updates, I forked this repository and updated it to be compatible with IDEA 2023.3 above while maintaining the existing themes, Dark and Storm. I will update and add new themes in the future (if any).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants