Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added pull request template & updated changelog #26

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

harrisonhjones
Copy link

@harrisonhjones harrisonhjones commented Jan 19, 2017

Missing Feature:

Repo is missing a PR template.

New Feature:

PR template added.


Doneness:

  • Be awesome for submitting a PR
  • CONTRIBUTING reviewed
  • Test(s) written to reproduce the problem or missing feature
  • Code written to solve the problem or implement the new feature
  • README updated with documentation (if applicable)
  • CHANGELOG updated with your change
  • Detailed commit messages present

@@ -1,6 +1,7 @@
### Next

* Your contribution here.
* Added pull request template - [@harrisonhjones](https://github.com/harrisonhjones/)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just want to nitpick on the format. Other lines end with a period :)

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done. Let me know if you think anything else needs to be updated.

	- Added period to CHANGELOG entry
	- Link to CONTRIBUTING fixed in template
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants