Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add state to callback functions #70

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mattotodd
Copy link

@mattotodd mattotodd commented Jun 3, 2016

I am using this package to write node-red bindings for alexa.

The issue is that the way that node-red processes messages, it can not respond to an http request until the end of a chain of nodes, and then it uses the express response object to respond.

These nodes do not know about one another, they only pass a message (javascript object) down the chain, and the express response object needs to be passed down that chain.

HTTP In ---> Do Some Processing --> Add Alexa Say Command --> HTTP Out

The way the library was currently written, I couldn't find a way to pass along the express response object.
So for now I'm including it it my package with the changes, but I'd rather include alexa-app as a dependency

The usage within my project can be found here

add state to callback functions
@coveralls
Copy link

Coverage Status

Coverage remained the same at 81.019% when pulling daa9664 on mattotodd:master into 72cd1f7 on matt-kruse:master.

@mattotodd
Copy link
Author

a love here?

@dblock
Copy link
Collaborator

dblock commented Dec 16, 2016

Sorry for the delay, we're back on track here. I think this is valuable. It would need tests and CHANGELOG to get this in. Care to do it @mattotodd?

@kevingilbert100
Copy link

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants