Fix using invalid joystick id in event handlers #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks, merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fix using incorrect id while handle joystick events.
Description
In the function getJoystick, the id pass as an argument refers to N'th joystick on the system (system device index). But this index is not the value which will identify this joystick in the future joystick events. The joystick's instance id (SDL_JoystickID) will be used there instead.
However, now we are using system device index as id while handle joystick events. It leads to crashes when handle events after connecting additional joysticks and pass wrong id to signals in update function when working with multiple joysticks.
Solution
Add additional instanceID field for SDL_JoystickID in QJoystickDevice. Use this field to identify joystick while handle events.
Note that "instanceID" field is permanent id of joystick (and it will not be changed untill joystick is reconnected), while "id" field can be changed.
Linked issues
Bug #6 is fixed now