Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add remapper plugin #406

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

diego-ojeda-binbash
Copy link

@diego-ojeda-binbash diego-ojeda-binbash commented Aug 22, 2024

Description
We run multiple Kubernetes clusters that we monitor via a centralized Prometheus/Alert Manager, and we have that integrated with Alerta.

Our Prometheus configuration intends to be "generic enough" because we our cluster hosts multiple tenants in their own namespaces, and we don't want to update Prometheus every time we onboard (or offboard) a new tenant.

The problem is that our alerts get grouped under the same alert because the alert fields that are used for deduplication are event, resource and environment. According to the Prometheus/Alerta config repo the resource field in Alerta is grabbed from the instance field, which in our case holds the cluster node name. That causes alerts that belong to different tenants to be grouped under the same alert, which can be confusing unless you go to the alert details and look for the tags in order to find the affected Kubernetes namespaces.

Fixes # (issue)
N/A

Changes
Include a brief summary of changes...

  • Add new "Remapper" plugin which allows remapping alert fields values according to given mapping rules passed via configuration.

Screenshots
N/A

Checklist

  • Pull request is limited to a single purpose
  • Code style/formatting is consistent
  • All existing tests are passing
  • Added new tests related to change
  • No unnecessary whitespace changes

Collaboration
When a user creates a pull request from a fork that they own, the user
generally has the authority to decide if other users can commit to the
pull request's compare branch. If the pull request author wants greater
collaboration, they can grant maintainers of the upstream repository
(that is, anyone with push access to the upstream repository) permission
to commit to the pull request's compare branch

See https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/allowing-changes-to-a-pull-request-branch-created-from-a-fork

@diego-ojeda-binbash diego-ojeda-binbash marked this pull request as ready for review August 22, 2024 22:04
@diego-ojeda-binbash diego-ojeda-binbash marked this pull request as draft August 23, 2024 15:36
@diego-ojeda-binbash diego-ojeda-binbash marked this pull request as ready for review August 26, 2024 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant