Skip to content

Commit

Permalink
Merge pull request #269 from alejandrohdezma/breaking/trait-remove
Browse files Browse the repository at this point in the history
Replace most `abstract class` definitions with `traits`
  • Loading branch information
alejandrohdezma authored Oct 10, 2022
2 parents d40ee96 + c3c4147 commit cb8614a
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 3 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ import org.http4s.Response
* @author
* José Gutiérrez
*/
abstract class Http4sHttpRoutesSuite extends Http4sSuite[Request[IO]] {
trait Http4sHttpRoutesSuite extends Http4sSuite[Request[IO]] {

/** The HTTP routes being tested.
*
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ import org.typelevel.ci.CIString
* @author
* José Gutiérrez
*/
abstract class Http4sSuite[Request] extends CatsEffectSuite with Http4sDsl[IO] with Http4sClientDsl[IO] with AllSyntax {
trait Http4sSuite[Request] extends CatsEffectSuite with Http4sDsl[IO] with Http4sClientDsl[IO] with AllSyntax {

/** Allows altering the name of the generated tests.
*
Expand Down
2 changes: 1 addition & 1 deletion modules/http4s-munit/src/main/scala/munit/HttpSuite.scala
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ import org.http4s.ember.client.EmberClientBuilder
* @author
* José Gutiérrez
*/
abstract class HttpSuite extends Http4sSuite[Request[IO]] with CatsEffectFunFixtures {
trait HttpSuite extends Http4sSuite[Request[IO]] with CatsEffectFunFixtures {

/** The base URI for all tests. This URI will prepend the one used in each test's request. */
def baseUri(): Uri
Expand Down

0 comments on commit cb8614a

Please sign in to comment.