Improve build process. Put commit sha in build. Add icon

.gitignore

@@ -9,3 +9,5 @@
 /build/
 /dist/
 /.env
+/src/_constants.py
+/venv_w/

Makefile

@@ -1,3 +1,4 @@
-release:
-	rm -rf ./dist ./build
-	pyinstaller src/main.py --name mulpyplayer --onefile --clean --add-data "assets:assets"
+# spec file generated unsing:
+# pyinstaller src/main.py --name mulpyplayer --onefile --clean --add-data "assets:assets"
+pyinstall:
+	pyinstaller mulpyplayer.spec

Makefile.bat

@@ -0,0 +1,2 @@
+:: spec fire generated using pyinstaller src/main.py --noconsole --name MulpyplayerWindows --onefile --clean --add-data "assets:assets" --icon assets/patricie.ico
+pyinstaller MulpyplayerWindows.spec

MulpyplayerWindows.spec

@@ -0,0 +1,39 @@
+# -*- mode: python ; coding: utf-8 -*-
+
+
+a = Analysis(
+    ['src\\main.py'],
+    pathex=[],
+    binaries=[],
+    datas=[('assets', 'assets')],
+    hiddenimports=[],
+    hookspath=[],
+    hooksconfig={},
+    runtime_hooks=[],
+    excludes=[],
+    noarchive=False,
+    optimize=0,
+)
+pyz = PYZ(a.pure)
+
+exe = EXE(
+    pyz,
+    a.scripts,
+    a.binaries,
+    a.datas,
+    [],
+    name='MulpyplayerWindows',
+    debug=False,
+    bootloader_ignore_signals=False,
+    strip=False,
+    upx=True,
+    upx_exclude=[],
+    runtime_tmpdir=None,
+    console=False,
+    disable_windowed_traceback=False,
+    argv_emulation=False,
+    target_arch=None,
+    codesign_identity=None,
+    entitlements_file=None,
+    icon=['assets\\patricie.ico'],
+)

mulpyplayer.spec

@@ -0,0 +1,48 @@
+# -*- mode: python ; coding: utf-8 -*-
+
+# write runtime constants
+import git
+
+_repo = git.Repo(search_parent_directories=True)
+_commit_sha = _repo.head.object.hexsha
+
+with open("src/_constants.py", "w") as f:
+    f.write(f'COMMIT_SHA = "{_commit_sha[:8]}"\n')
+# end constants
+
+a = Analysis(
+    ["src/main.py", "src/_constants.py"],
+    pathex=[],
+    binaries=[],
+    datas=[("assets", "assets")],
+    hiddenimports=[],
+    hookspath=[],
+    hooksconfig={},
+    runtime_hooks=[],
+    excludes=[],
+    noarchive=False,
+    optimize=0,
+)
+pyz = PYZ(a.pure)
+
+exe = EXE(
+    pyz,
+    a.scripts,
+    a.binaries,
+    a.datas,
+    [],
+    name="mulpyplayer",
+    debug=False,
+    bootloader_ignore_signals=False,
+    strip=False,
+    upx=True,
+    upx_exclude=[],
+    runtime_tmpdir=None,
+    console=True,
+    disable_windowed_traceback=False,
+    argv_emulation=False,
+    target_arch=None,
+    codesign_identity=None,
+    entitlements_file=None,
+    icon=[],
+)

src/main.py

@@ -1,16 +1,21 @@
-# for pyinstall as explained here:
-# https://api.arcade.academy/en/development/tutorials/bundling_with_pyinstaller/index.html#handling-data-files
+import argparse
 import os
 import sys
 
+# for pyinstall as explained here:
+# https://api.arcade.academy/en/development/tutorials/bundling_with_pyinstaller/index.html#handling-data-files
+_sha = ""
 if getattr(sys, "frozen", False) and hasattr(sys, "_MEIPASS"):
     os.chdir(sys._MEIPASS)
-# end for pyinstall
-
-import argparse
+    # load constants created at build time
+    import _constants
 
-from bcp.gui import main
+    _sha = _constants.COMMIT_SHA
+os.environ["COMMIT_SHA"] = _sha
+# end for pyinstall
 
+# this import must be placed after os.chdir
+from bcp.gui import main  # noqa: E402
 
 if __name__ == "__main__":
     parser = argparse.ArgumentParser()