multi: Note benchmarks that perform buffer reuse #155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds an explicit note for the benchmarks which perform buffer reuse during marshalling operations. This improves fairness when comparing the performance of different benchmarks that may or may not offer this feature. Given that buffer reuse is a marshalling feature and unsafe string decoding is an unmarshalling feature, for serializers that support both features, they are both coalesced into a single benchmark to avoid unnecessarily increasing the size of the report.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds an explicit note for the benchmarks which perform buffer reuse during marshalling operations. This improves fairness when comparing the performance of different benchmarks that may or may not offer this feature.
Given that buffer reuse is a marshalling feature and unsafe string decoding is an unmarshalling feature, for serializers that support both features, they are both coalesced into a single benchmark to avoid unnecessarily increasing the size of the report.
Discussion of need from #148.