Skip to content

fix(core): lowercase generated physical names #1257

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
john-royal wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix(core): lowercase generated physical names #1257

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
af90bd7
fix(cloudflare): lowercase generated worker name for websites
john-royal Dec 11, 2025
79357d6
lowercase generated physical names
john-royal Dec 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions alchemy/src/cloudflare/worker.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -851,9 +851,7 @@ const _Worker = Resource(
) {
let adopt = props.adopt ?? this.scope.adopt;
const workerName =
props.name ??
this.output?.name ??
this.scope.createPhysicalName(id).toLowerCase();
props.name ?? this.output?.name ?? this.scope.createPhysicalName(id);
if (this.phase === "create" && !props.adopt) {
// it is possible that this worker already exists and was created by the old Website wrapper with a nested scope
// we need to detect this and set adopt=true so that the previous version will be adopted seamlessly
Expand Down
3 changes: 2 additions & 1 deletion alchemy/src/scope.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -336,7 +336,8 @@ export class Scope {
const stage = this.stage;
return [app, ...this.chain.slice(2), id, stage]
.map((s) => s.replaceAll(/[^a-z0-9_-]/gi, delimiter))
.join(delimiter);
.join(delimiter)
.toLowerCase();
}

public async spawn<
Expand Down
Loading