Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: switch tools from host to exec cfg #1

Merged
merged 1 commit into from
Jul 30, 2024

Conversation

peakschris
Copy link

Bazel 7 with --incompatible_disable_starlark_host_transition (which we use by default) is giving the error:

ERROR: Traceback (most recent call last):
        File "D:/udu/b/qpawu7hm/external/rules_antlr/antlr/antlr2.bzl", line 71, column 28, in <toplevel>
                "_tool": attr.label(
Error in label: 'cfg = "host"' is deprecated and should no longer be used. Please use 'cfg = "exec"' instead.

I'm not sure your plan for accepting PRs into your hoist branch, but if suitable, I would like to contribute as we find issues in our adoption of rules_antlr

@albertocavalcante
Copy link
Owner

LGTM! Thanks @peakschris! Appreciate your contribution.

Context: bazelbuild/bazel#17032

@albertocavalcante albertocavalcante merged commit cf21bd1 into albertocavalcante:master Jul 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants