Return nonzero exit code when issues are found #36
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PLPeeters
force-pushed
the
bugfix/pre-commit
branch
from
15dd206 to
ee39c4b
Compare
PLPeeters
force-pushed
the
bugfix/pre-commit
branch
from
ee39c4b to
edf4c54
Compare
|
Can this PR be landed? It seems like it would make the tool much more useful. |
Sure, I am going to create new release this week. It will include this fix. |
sbc100
added a commit
to emscripten-core/emscripten
that referenced
this pull request
Sep 24, 2025
There are still quite a few false positives after this but they are fall into basically 2 classes: - Subclasses of TestCase, which are explicitly used - Subclasses of Library, which are no explicitly user - Settings, which are only ever read in the JS compiler. I think we should probably wait until the `deadcode` tool at least supports returning error codes before we try to integrate into CI. See albertas/deadcode#36
|
@albertas Don't want to be pushy, but I'm eagerly awaiting a release on this :) |
We ended up use |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #20, #35