Downsample tests #1
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Fix labeled image truncation * Parameterise test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I maintain this is bad and/or wrong but I'm not going to continue arguing the point, so will leave these tests here for my own future reference
Downsampling
The current behaviour is arguably unintuitive with respect to downsampling as demonstrated in the other 4 unit tests added. There is some discussion in qupath#25 about whether this behaviour should change. In my view, if retaining the current behaviour, we should warn users (either in code or documentation but ideally both) that they may be receiving rasterised images, and that they should be supplying coordinates based on the downsampled image, rather than the full-sized image that the labeled image server is created from.