prefer mutate over mutateAsync

alan2207 · May 10, 2024 · 0b98df5 · 0b98df5
1 parent b52d0c7
commit 0b98df5
Show file tree

Hide file tree

Showing 8 changed files with 13 additions and 17 deletions.
diff --git a/src/components/layouts/dashboard-layout.tsx b/src/components/layouts/dashboard-layout.tsx
@@ -23,7 +23,7 @@ type SideNavigationItem = {
 };
 
 export function DashboardLayout({ children }: { children: React.ReactNode }) {
-  const { mutate: logout } = useLogout();
+  const logout = useLogout();
   const { checkAccess } = useAuthorization();
   const navigate = useNavigate();
   const navigation = [
@@ -143,7 +143,7 @@ export function DashboardLayout({ children }: { children: React.ReactNode }) {
               <DropdownMenuSeparator />
               <DropdownMenuItem
                 className={cn('block px-4 py-2 text-sm text-gray-700 w-full')}
-                onClick={() => logout({})}
+                onClick={() => logout.mutate({})}
               >
                 Sign Out
               </DropdownMenuItem>

diff --git a/src/features/comments/components/create-comment.tsx b/src/features/comments/components/create-comment.tsx
@@ -37,8 +37,8 @@ export const CreateComment = ({ discussionId }: CreateCommentProps) => {
     >
       <Form
         id="create-comment"
-        onSubmit={async (values) => {
-          await createCommentMutation.mutateAsync({
+        onSubmit={(values) => {
+          createCommentMutation.mutate({
             data: values,
           });
         }}

diff --git a/src/features/comments/components/delete-comment.tsx b/src/features/comments/components/delete-comment.tsx
@@ -33,9 +33,7 @@ export const DeleteComment = ({ id, discussionId }: DeleteCommentProps) => {
           isLoading={deleteCommentMutation.isPending}
           type="button"
           variant="destructive"
-          onClick={async () =>
-            await deleteCommentMutation.mutateAsync({ commentId: id })
-          }
+          onClick={() => deleteCommentMutation.mutate({ commentId: id })}
         >
           Delete Comment
         </Button>

diff --git a/src/features/discussions/components/create-discussion.tsx b/src/features/discussions/components/create-discussion.tsx
@@ -35,8 +35,8 @@ export const CreateDiscussion = () => {
       >
         <Form
           id="create-discussion"
-          onSubmit={async (values) => {
-            await createDiscussionMutation.mutateAsync({ data: values });
+          onSubmit={(values) => {
+            createDiscussionMutation.mutate({ data: values });
           }}
           schema={createDiscussionInputSchema}
         >

diff --git a/src/features/discussions/components/delete-discussion.tsx b/src/features/discussions/components/delete-discussion.tsx
@@ -29,8 +29,8 @@ export const DeleteDiscussion = ({ id }: DeleteDiscussionProps) => {
             isLoading={deleteDiscussionMutation.isPending}
             type="button"
             variant="destructive"
-            onClick={async () =>
-              await deleteDiscussionMutation.mutateAsync({ discussionId: id })
+            onClick={() =>
+              deleteDiscussionMutation.mutate({ discussionId: id })
             }
           >
             Delete Discussion

diff --git a/src/features/discussions/components/update-discussion.tsx b/src/features/discussions/components/update-discussion.tsx
@@ -41,8 +41,8 @@ export const UpdateDiscussion = ({ discussionId }: UpdateDiscussionProps) => {
       >
         <Form
           id="update-discussion"
-          onSubmit={async (values) => {
-            await updateDiscussionMutation.mutateAsync({
+          onSubmit={(values) => {
+            updateDiscussionMutation.mutate({
               data: values,
               discussionId,
             });

diff --git a/src/features/discussions/routes/__tests__/discussion.test.tsx b/src/features/discussions/routes/__tests__/discussion.test.tsx
@@ -51,8 +51,6 @@ test('should update discussion', async () => {
   const titleUpdate = '-Updated';
   const bodyUpdate = '-Updated';
 
-  console.log('fakeDiscussion', fakeDiscussion.title);
-
   await userEvent.click(
     screen.getByRole('button', { name: /update discussion/i }),
   );

diff --git a/src/features/users/components/update-profile.tsx b/src/features/users/components/update-profile.tsx
@@ -35,8 +35,8 @@ export const UpdateProfile = () => {
     >
       <Form
         id="update-profile"
-        onSubmit={async (values) => {
-          await updateProfileMutation.mutateAsync({ data: values });
+        onSubmit={(values) => {
+          updateProfileMutation.mutate({ data: values });
         }}
         options={{
           defaultValues: {