Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP Use Pulumi to create Entra applications #2248

Draft
wants to merge 7 commits into
base: develop
Choose a base branch
from

Conversation

jemrobinson
Copy link
Member

✅ Checklist

  • You have given your pull request a meaningful title (e.g. Enable foobar integration rather than 515 foobar).
  • You are targeting the appropriate branch. If you're not certain which one this is, it should be develop.
  • Your branch is up-to-date with the target branch (it probably was when you started, but it may have changed since then).

🚦 Depends on

n/a

⤴️ Summary

Replace creation of Entra applications through the SDK with creation through pulumi-azuread

🌂 Related issues

Closes #2215

🔬 Tests

Tested on a fresh SRE deployment

@jemrobinson jemrobinson requested a review from a team as a code owner October 22, 2024 12:17
Copy link

github-actions bot commented Oct 22, 2024

Coverage report

Click to see where and how coverage changed

FileStatementsMissingCoverageCoverage
(new stmts)
Lines missing
  data_safe_haven/infrastructure/components/composite
  entra_application.py 22-29, 54, 79, 103-149
  data_safe_haven/infrastructure/components/dynamic
  __init__.py
  data_safe_haven/infrastructure/programs
  declarative_sre.py 158
  imperative_shm.py 163
  data_safe_haven/infrastructure/programs/sre
  entra.py 27-29, 42-46, 56-123
  identity.py 39-40
  remote_desktop.py 59-60
Project Total  

This report was generated by python-coverage-comment-action

@jemrobinson jemrobinson changed the title Use Pulumi to create Entra applications WIP Use Pulumi to create Entra applications Oct 22, 2024
@jemrobinson jemrobinson marked this pull request as draft October 22, 2024 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create Entra applications with Pulumi
1 participant