-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Pulumi/dsh Python mismatch #2240
Conversation
3fa0e01
to
95a2476
Compare
Coverage reportClick to see where and how coverage changed
This report was generated by python-coverage-comment-action |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure this will fix #2239 on its own. I don't think it is just the Python interpreter but also the PYTHONPATH
.
Seems to work on my Docker container |
Yeah, it also worked for me. I'm not sure why, but I assume it sets the path correctly behind the scenes? |
Interesting, maybe the interpreter "knows" where it's modules are, or the default path is relative to the executable file or something. If this works on its own though I don't see much benefit in also finding and setting the venv path 👍. |
I tried the venv method and couldn't get it to work, so if this fix works for @helendduncan then I'm happy with it :) |
Reading this a second time, does that mean this works in an environment where it didn't work before (a |
|
Great, that sounds like a positive result for this change working then 🎉. |
Confirmed working by @helendduncan |
✅ Checklist
Enable foobar integration
rather than515 foobar
).develop
.🚦 Depends on
n/a
Set PULUMI_PYTHON_CMD to use the same Python executable that is being used by dsh.
Thanks for the pointer @craddm !
🌂 Related issues
Closes #2239
🔬 Tests
Tested locally, but we should test on the rc1 branch once this is merged into it