[2.x] Add @render() blade directiive
#24
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Linking to this issue #19 |
| * @return string Rendered HTML content. | ||
| */ | ||
| Blade::directive('render', function ($blocks) { | ||
| return "<?php echo app('laravel-editorjs')->render($blocks); ?>"; |
There was a problem hiding this comment.
@lmottasin What about the exception?
render() method throws exception when it fails to render.
There was a problem hiding this comment.
There was a problem hiding this comment.
What I found is that handling the exception is not a valid solution. The developer must validate the JSON before saving it to the database, so the current approach is fine.
alaminfirdows
requested changes
Oct 22, 2024
| * @param mixed $blocks The blocks of content to be rendered. | ||
| * @return string Rendered HTML content. | ||
| */ | ||
| Blade::directive('render', function ($blocks) { |
There was a problem hiding this comment.
Could you please change this name to include the "editorjs" prefix or something relevant? It might create conflicts with other names.
Thank you!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
eg.
@render($post->body)helps to simplify things for devs.