Exclude test data from being published to crates.io #144
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The build seem to fail due to rust-lang/rust#138907. I'm happy to push a fix for that as well |
chrisduerr
requested changes
Oct 1, 2025
There was a problem hiding this comment.
The build seem to fail due to rust-lang/rust#138907. I'm happy to push a fix for that as well
Yeah if you could put that into a separate commit that comes before this one, I'd appreciate it.
Otherwise LGTM.
These data are "binary" so somewhat hard to review. Also they increase the package size by quite a bit. This changes reduces the package size from 17 files, 316.5KiB (56.8KiB compressed) to 10 files, 155.0KiB (34.1KiB compressed) which results in a ~34GB/month traffic reduction for crates.io assuming the current 1.5 million downloads per month.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These data are "binary" so somewhat hard to review. Also they increase the package size by quite a bit. This changes reduces the package size from 17 files, 316.5KiB (56.8KiB compressed) to 10 files, 155.0KiB (34.1KiB compressed) which results in a ~34GB/month traffic reduction for crates.io assuming the current 1.5 million downloads per month.
I'm also happy to switch this to an exclude based approach if you rather prefer that variant.