Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug fixes and updates 05-04-2017 Issues #10, #11 & #13 #12

Open
wants to merge 13 commits into
base: master
Choose a base branch
from

Conversation

NateNjuguna
Copy link

@NateNjuguna NateNjuguna commented Apr 5, 2017

Just a compliment to the already great module:

  • Payment Notification failed because there was no reference to PaymentService. Fixed by sending an instance and returning valid middleware.
  • Base64 encoding the hashed password resulted in an incorrect string using crypto-js. Fixed by changing the crypto module to node's native crypto and encoding a buffer of the hash to base64.
  • Excluded the reference parameter transactionStatusRequest xml template.
  • Fixed bugs caused by omission of the reference and timestamp parameter in checkout requests.
  • Updated relevant config files > package.json, README.md and .gitignore

@NateNjuguna NateNjuguna changed the title Bug fixes and updates 05-04-2017 Bug fixes and updates 05-04-2017 Issues #2 & #3 Apr 5, 2017
@NateNjuguna NateNjuguna changed the title Bug fixes and updates 05-04-2017 Issues #2 & #3 Bug fixes and updates 05-04-2017 Issues #10 & #11 Apr 5, 2017
@NateNjuguna NateNjuguna closed this Apr 6, 2017
@NateNjuguna
Copy link
Author

NateNjuguna commented Apr 6, 2017

Issue #11 had a bug. Fixed it

@NateNjuguna NateNjuguna reopened this Apr 6, 2017
@NateNjuguna NateNjuguna changed the title Bug fixes and updates 05-04-2017 Issues #10 & #11 Bug fixes and updates 05-04-2017 Issues #10, #11 & #13 Apr 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant