Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Combined fixes #47

Open
wants to merge 30 commits into
base: release-1.0
Choose a base branch
from
Open

Combined fixes #47

wants to merge 30 commits into from

Conversation

pash7ka
Copy link
Contributor

@pash7ka pash7ka commented Jan 14, 2021

Fixes included

  • Fix SavingsModule bugs which made hack possible
  • Fixes inspired by MixBytes audit
  • Fix high gas issue with rewards

Contracts changed (exluding tests)

  • contracts/interfaces/access/IAccessModule.sol
  • contracts/modules/access/AccessChecker.sol
  • contracts/modules/access/AccessModule.sol
  • contracts/modules/reward/RewardVestingModule.sol
  • contracts/modules/savings/RewardDistributions.sol
  • contracts/modules/savings/SavingsModule.sol
  • contracts/modules/staking/StakingPool.sol
  • contracts/modules/staking/StakingPoolBase.sol

pash7ka and others added 30 commits November 13, 2020 14:11
@pash7ka
Add reentrancy guard and check deposited tokens are registered
51da2a7
@pash7ka
Add whitelist check for intermediate senders (which can only be contr…
93e379d 
…acts).
@pash7ka
Add check for gas left
e8e264f
@pash7ka
Fix compilation errors (wip)
3ada219
@pash7ka
Fix stack too deep error
ba422b6
@0xbuidlman
add crytic-config.json
65b644a
@0xbuidlman
crytic update
c5f586f
@pash7ka
ignore VSCode settings
7f0e326
@pash7ka
DD-1493 Fix MixBytes MAJOR 1
a54edb1
@pash7ka
DD-1493 Fix MixBytes MAJOR 2
38c4305
@pash7ka
DD-1493 Fix MixBytes WARNINGS 1
f64d86a
@pash7ka
DD-1493 Fix MixBytes WARNINGS 2
6385835
@pash7ka
DD-1493 Fix MixBytes WARNINGS 3
fe1e4da
@pash7ka
DD-1493 Fix MixBytes COMMENTS 1
5379753
@pash7ka
Add prettier and update ABIs
8062eca
@pash7ka
DD-1493 Fix MixBytes COMMENTS 2
6bb16cf
@pash7ka
DD-1511 Do not iterate on distributions if user has no shares
1de59fa
@pash7ka
Move RewardDistributionModule_migration test to subfolder to maintain…
07d6be5 
… test folder structure
@pash7ka
DD-1511 Improve fix
4d69ce3
@pash7ka
DD-1511 Add test for reward migration
c476c1b
@pash7ka
Fix test after file move
a650826
@pash7ka
DD-1571 Upgrade truffle and truffle-upgrades to correctly run test wi…
4ad01d5 
…th contract upgrades
@pash7ka
DD-1571 test improvement
4e779f8
@pash7ka
DD-1571 Return UNFIXED version of RewardDistribution to work with tes…
ff94e52 
…t (it should fail)
@pash7ka
DD-1571 improving test [wip]
30cd597
@pash7ka
DD-1571 Fix SavingsModuleOld test contract to decrease it's size
b0158e9
@pash7ka
DD-1571 test [wip]
5fbf6ae
@pash7ka
Revert "DD-1571 Return UNFIXED version of RewardDistribution to work …
bfd61a8 
…with test (it should fail)"

This reverts commit ff94e52.
@pash7ka
DD-1715 rinkeby upgraded
d5257d5
@pash7ka
DD-1746 Delphi upgrade
8175086
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@pash7ka @0xbuidlman