-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FIX] Exclude frozen.yaml from pre-commit because it is generated automatically #97
base: main
Are you sure you want to change the base?
Conversation
…omatically If we delete it and re-create it, it is full of unwanted diff because of pre-commit reformat
Thnaks a lot |
is it may be better to only include local-src ? |
It makes sense for me. (If we still can exclude some stuff inside local-src) |
can you give me some examples ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you need also to update this file: update_oca_file.py
Well, I am not sure, but I think I had problem already, for instance with CSV files used for some tests in any module. Another one, but quite more specific... for an anonymous customer in v16, they have terrible printers and the native barcode generator from Odoo does not work well for them, I have a big javascript copy pasted that generates barcode in a module. Also, in the current exclude, there is stuff from local-src (.html, cassettes, README, etc) so I guess we'll still want to exclude all this if we include only local-src. (I just want to be sure both are compatible (exclude and include) |
Not sure how/what I should update |
These pre-commit files are derived from oca, so instead of patching the result of the script, you can patch in update_oca_file your example makes sense. I guess, we want to put the exclusion closer to its place (ie: next to local-src/some_modules/data/copypastedfile ) |
If we delete it and re-create it, it is full of unwanted diff because of pre-commit reformat
@bealdav @Kev-Roche @sebastienbeau @hparfr