Adds Styler to the project #26
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Styler fixes some of the credo checks that can be automated, so we don't have to think about it. It also rearranges the file into a standard order. This helps because while we are working, we can stay at the same level as the code we are writing and add our imports and everything there. Then when we format, it will move those to the correct locations so we never have to think about it again. There is one side effect. Since some of our module-attributes depended on other module-attributes, i.e., documentation, we need to move those to bare identifiers outside the module. These identifiers only exist during the compilation process. I believe this may help keep things consistent even with outside contributors and without putting as much onus on them.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Styler fixes some of the credo checks that can be automated, so we don't have to think about it. It also rearranges the file into a standard order. This helps because while we are working, we can stay at the same level as the code we are writing and add our imports and everything there. Then when we format, it will move those to the correct locations so we never have to think about it again.
There is one side effect. Since some of our module-attributes depended on other module-attributes, i.e., documentation, we need to move those to bare identifiers outside the module. These identifiers only exist during the compilation process.
I believe this may help keep things consistent even with outside contributors and without putting as much onus on them.