Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: resolveKind flow for composite binding #1407

Merged
merged 3 commits into from
Feb 19, 2025
Merged

fix: resolveKind flow for composite binding #1407

merged 3 commits into from
Feb 19, 2025

Conversation

ankitk-me
Copy link
Contributor

Fixes #1406

@ankitk-me ankitk-me requested a review from jfallows February 17, 2025 19:14
jfallows
jfallows reviewed Feb 17, 2025
View reviewed changes
Copy link
Contributor

@jfallows jfallows left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add a test that verified the metrics are being recorded?

Perhaps via the test binding.

.../engine/src/main/java/io/aklivity/zilla/runtime/engine/internal/registry/EngineRegistry.java Outdated Show resolved Hide resolved
...gine/src/main/java/io/aklivity/zilla/runtime/engine/internal/registry/NamespaceRegistry.java Outdated Show resolved Hide resolved
@jfallows jfallows merged commit 19067d0 into aklivity:develop Feb 19, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jfallows jfallows jfallows approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Java Agent Error while sending Data to Open Telemtry Endpoint (OTEL Endpoint)
2 participants
@ankitk-me @jfallows