Avoid warnings during build on several compilers #695
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
August 20, 2024 22:10
If jansson is built with -DCMAKE_BUILD_TYPE=Release, gcc 10.x (specifically,
gcc (Debian 10.2.1-6) 10.2.1 20210110) produces the following warning:
jansson/src/error.c:25:9: warning: 'strncpy' specified bound depends
on the length of the source argument [-Wstringop-overflow=]
This commit fixes this behavior.
Further info:
https://stackoverflow.com/questions/66930308/gcc-false-positive-warning-on-strncpy-usage
If jansson is built with -DCMAKE_BUILD_TYPE=Release, lcc 1.25 (specifically,
lcc:1.25.23:Apr--7-2022:e2k-v4-linux) and 1.26 (specifically,
lcc:1.26.20:Jun--6-2023:e2k-v4-linux) produce the following warnings:
lcc: "/root/jansson/src/dtoa.c", line 3491: in function "strtod__unused":
lcc: "/root/jansson/src/dtoa.c", line 4212: warning: variable "bb" may be
used uninitialized [-Wmaybe-uninitialized]
lcc: "/root/jansson/src/dtoa.c", line 4213: warning: variable "bd" may be
used uninitialized [-Wmaybe-uninitialized]
lcc: "/root/jansson/src/dtoa.c", line 4214: warning: variable "bs" may be
used uninitialized [-Wmaybe-uninitialized]
lcc: "/root/jansson/src/dtoa.c", line 4216: warning: variable "delta" may
be used uninitialized [-Wmaybe-uninitialized]
lcc: "/root/jansson/src/dtoa.c", line 5014: in function "dtoa_r":
lcc: "/root/jansson/src/dtoa.c", line 5513: warning: variable "ulpmask" may
be used uninitialized [-Wmaybe-uninitialized]
In addition, gcc 6.x (specifically, gcc (Debian 6.3.0-18+deb9u1) 6.3.0
20170516) produces only the last warning, probably because it may figure out
that strtod__unused() is actually unused, and skip this function.
This commit fixes this behavior.
If jansson is built on Windows (specifically, with MinGW 7.3.0), it produces
the following warnings:
C:/Users/ci_user/jansson/examples/simple_parse.c:93:30: warning: unknown
conversion type character 'l' in format [-Wformat=]
C:/Users/ci_user/jansson/examples/simple_parse.c:106:29: warning: unknown
conversion type character 'l' in format [-Wformat=]
Plus there are more additional warnings caused by code being treated
incorrectly because of these two.
It means it can't recognize "%lld" format specifier, which is, for Windows,
should be "%I64d". It has already been done for JSON_INTEGER_FORMAT, and I did
the same way for new macro, JSON_LONG_LONG_FORMAT.
So this commit fixes this behavior.
Further info:
https://sourceforge.net/p/mingw/bugs/2190/
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Release build of jansson's
masterproduces some warnings on several compilers, namely gcc 6.x, gcc 10.x, and lcc (eLbrus C/C++ compiler) 1.25 and 1.26. In addition, it uses incorrect format conversions onWIN32in a couple places.This PR fixes all this issues.
On each of my setups (different CPU arches, compilers, OS, etc.) both Release and Debug builds are now warningless, and all CTest tests pass successfully.