fix: update CEO agent table, clarify Sacred Rule enforcement, add profiler to CLI#803
Open
gx-ai-architect wants to merge 1 commit into
Open
fix: update CEO agent table, clarify Sacred Rule enforcement, add profiler to CLI#803gx-ai-architect wants to merge 1 commit into
gx-ai-architect wants to merge 1 commit into
Conversation
- Add Failure Analyst and Refiner to CEO agent table - Add review criteria for Failure Analyst and Refiner - Document Sacred Rules enforcement status (Rules 4-9 are honor-system) - Clarify factory eval is a permitted CEO CLI command - Add profiler to CLI argparse choices to match AgentRole type Addresses #796, #798, #800, #801
Sentrux Quality ReportAbsoluteDiff (vs base branch) |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #803 +/- ##
=======================================
Coverage 87.12% 87.12%
=======================================
Files 81 81
Lines 12209 12209
=======================================
Hits 10637 10637
Misses 1572 1572 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Documentation and minor code fixes for CEO prompt and CLI consistency.
Addresses: #796, #798, #800, #801
Changes
factory eval(CLI wrapper) is allowed per Sacred Rule 8profilerto matchAgentRoleLiteral typeQuestions for reviewers
@akashgit @gx-ai-architect — need your input on these:
Profiler agent: keep or remove?
profilerhas a prompt file (factory/agents/prompts/profiler.md) and is in theAgentRoletype, but no workflow invokes it and it wasn't in the CLI argparse. I added it to argparse for consistency — but should we remove the profiler entirely as dead code from the refactoring?Sacred Rules 4-5: implement or accept as honor-system?
Rules 4 (no test deletion) and 5 (no test quality degradation) have zero programmatic enforcement. I documented this as the current state. Should we:
Should
factory evalbe explicitly in the CEO permitted list?The CEO already runs
factory evaldirectly (trace evidence: 3x inbc24771b). I clarified this in the permitted actions. But given Sacred Rule 8's spirit of "delegate ALL technical work" — should eval always go through QA instead?Test plan
factory agent --helpshows profiler in the role choices🤖 Generated with Claude Code