Chop the protocol and hostport information off absolute URLs #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `http://localhost:3000/` part in e.g. `http://localhost:3000/static/client/my/logo.svg` tends to not work in very simple cases, such as when accessing your development Meteor app through its IP address or host name (e.g. `http://1.2.3.4:3000/`). Just chop it off, and trust the browser to resolve e.g. `/static/client/my/logo.svg` relative to whatever protocol, host and port the Meteor app was loaded from in the first place.
|
Thanks for contributing! I'll have to think about this a bit. I see your point, but there's at least one reason why I did it this way, and that's for ease of use when creating links to put in an email since the email won't know what domain it came from. I can't remember at the moment if there were any other reasons. |
domq
pushed a commit
to epfl-si/wp-veritas
that referenced
this pull request
Jan 24, 2019
I happen to think that akanix42/meteor-static-assets#6 would be an even better idea, but from its comment thread it's going nowhere fast.
domq
pushed a commit
to epfl-si/wp-veritas
that referenced
this pull request
Jan 24, 2019
I happen to think that akanix42/meteor-static-assets#6 would be an even better idea, but from its comment thread it's going nowhere fast.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
http://localhost:3000/part in e.g.http://localhost:3000/static/client/my/logo.svgtends to not work in very simple cases, such aswhen accessing your development Meteor app through its IP address or
host name (e.g.
http://1.2.3.4:3000/). Just chop it off, and trust thebrowser to resolve e.g.
/static/client/my/logo.svgrelative towhatever protocol, host and port the Meteor app was loaded from in the
first place.
I am not aware of any case where we would be worse off by doing this.