Changes for use of double[] instead of pointers for some funcs (deals with #53) #57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@fpl - are you able to add a test for this? That will identify any future cases where these functions are updated incorrectly. |
Will do. |
fpl
added a commit
to fpl/Geo-GDAL-FFI
that referenced
this pull request
Nov 15, 2023
Might help with CI failures.
Might help with CI failures.
… that indicates success for GDAL
* succesfully -> successfully
|
Superseded by #65 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GDALApplyGeoTransform needs to fix only the first double* parameter and leaving intact the final two ones. Even,
using the number of expected values in the arrays would be better, so
parse_h.plprobably needs a revision for a better overriding mechanism.