Skip to content

Commit

Permalink
Continuation of PR #1040 - code cleanup and comments
Browse files Browse the repository at this point in the history
- remove unused errors from Kicker and Taker actions libraries
- improve natspec with revert error on CRA
  • Loading branch information
grandizzy committed Dec 21, 2023
1 parent 3f7525a commit ffefea1
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 5 deletions.
3 changes: 1 addition & 2 deletions src/libraries/external/KickerActions.sol
Original file line number Diff line number Diff line change
Expand Up @@ -96,8 +96,6 @@ library KickerActions {
error AuctionActive();
error BorrowerOk();
error InsufficientLiquidity();
error InsufficientLP();
error InvalidAmount();
error NoReserves();
error PriceBelowLUP();
error ReserveAuctionTooSoon();
Expand Down Expand Up @@ -210,6 +208,7 @@ library KickerActions {
* @dev update `reserveAuction.kicked` timestamp state
* @dev === Reverts on ===
* @dev no reserves to claim `NoReserves()`
* @dev 5 days not passed `ReserveAuctionTooSoon()`
* @dev === Emit events ===
* @dev - `KickReserveAuction`
*/
Expand Down
4 changes: 1 addition & 3 deletions src/libraries/external/TakerActions.sol
Original file line number Diff line number Diff line change
Expand Up @@ -117,9 +117,7 @@ library TakerActions {
error InsufficientCollateral();
error InvalidAmount();
error NoAuction();
error NoReserves();
error NoReservesAuction();
error ReserveAuctionTooSoon();

/***************************/
/*** External Functions ***/
Expand Down Expand Up @@ -273,7 +271,7 @@ library TakerActions {
* @dev === Write state ===
* @dev decrement `reserveAuction.unclaimed` accumulator
* @dev === Reverts on ===
* @dev not kicked or `72` hours didn't pass `NoReservesAuction()`
* @dev not kicked or `72` hours passed `NoReservesAuction()`
* @dev 0 take amount or 0 AJNA burned `InvalidAmount()`
* @dev === Emit events ===
* @dev - `ReserveAuction`
Expand Down

0 comments on commit ffefea1

Please sign in to comment.