-
Notifications
You must be signed in to change notification settings - Fork 5.3k
Transform TextInput to es6 class #5805
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
One of the public type files has been updated, plase make sure there are no backwards incompatible changes done in the PR. |
One of the public type files has been updated, plase make sure there are no backwards incompatible changes done in the PR. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #5805 +/- ##
==========================================
+ Coverage 87.67% 87.70% +0.02%
==========================================
Files 614 614
Lines 45940 45887 -53
Branches 7529 7516 -13
==========================================
- Hits 40277 40244 -33
+ Misses 5663 5643 -20
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ace-internal.d.ts
Outdated
@@ -1292,6 +1287,13 @@ export namespace Ace { | |||
export interface ScrollbarEvents { | |||
"scroll": (e: { data: number }) => void; | |||
} | |||
|
|||
export interface AriaOptions { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this interface is fairly specific to text input, do you think it could make sense to name it accordingly? (e.g. something like TextInputAriaOptions
)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That makes perfect sense. Missed that in process, thanks for correction
One of the public type files has been updated, plase make sure there are no backwards incompatible changes done in the PR. |
Thanks for the change, looks good to me, could you resolve the merge conflicts |
# Conflicts: # types/ace-ext.d.ts
One of the public type files has been updated, plase make sure there are no backwards incompatible changes done in the PR. |
Done! |
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Pull Request Checklist:
ace.d.ts
) and its references: