Skip to content

Transform TextInput to es6 class #5805

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jun 5, 2025
Merged

Conversation

mkslanc
Copy link
Contributor

@mkslanc mkslanc commented May 9, 2025

Issue #, if available:

Description of changes:

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Pull Request Checklist:

Sorry, something went wrong.

Copy link

github-actions bot commented May 9, 2025

One of the public type files has been updated, plase make sure there are no backwards incompatible changes done in the PR.

mkslanc added 2 commits May 22, 2025 13:06
Copy link

One of the public type files has been updated, plase make sure there are no backwards incompatible changes done in the PR.

Copy link

codecov bot commented May 22, 2025

Codecov Report

Attention: Patch coverage is 74.77477% with 112 lines in your changes missing coverage. Please review.

Project coverage is 87.70%. Comparing base (b45e94c) to head (2d3e346).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
src/keyboard/textinput.js 74.77% 112 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5805      +/-   ##
==========================================
+ Coverage   87.67%   87.70%   +0.02%     
==========================================
  Files         614      614              
  Lines       45940    45887      -53     
  Branches     7529     7516      -13     
==========================================
- Hits        40277    40244      -33     
+ Misses       5663     5643      -20     
Flag Coverage Δ
unittests 87.70% <74.77%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@@ -1292,6 +1287,13 @@ export namespace Ace {
export interface ScrollbarEvents {
"scroll": (e: { data: number }) => void;
}

export interface AriaOptions {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this interface is fairly specific to text input, do you think it could make sense to name it accordingly? (e.g. something like TextInputAriaOptions)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That makes perfect sense. Missed that in process, thanks for correction

Copy link

One of the public type files has been updated, plase make sure there are no backwards incompatible changes done in the PR.

@akoreman
Copy link
Contributor

akoreman commented Jun 4, 2025

Thanks for the change, looks good to me, could you resolve the merge conflicts

# Conflicts:
#	types/ace-ext.d.ts
Copy link

github-actions bot commented Jun 5, 2025

One of the public type files has been updated, plase make sure there are no backwards incompatible changes done in the PR.

@mkslanc
Copy link
Contributor Author

mkslanc commented Jun 5, 2025

Thanks for the change, looks good to me, could you resolve the merge conflicts

Done!

@akoreman akoreman merged commit dd9fdf5 into ajaxorg:master Jun 5, 2025
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants