Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Nord theme (https://www.nordtheme.com/) #4203

Merged
merged 12 commits into from Mar 8, 2020
Merged

Add Nord theme (https://www.nordtheme.com/) #4203

merged 12 commits into from Mar 8, 2020

Conversation

ghost
Copy link

@ghost ghost commented Mar 3, 2020

Issue #, if available: #4202

Description of changes: Make the popular Nord theme available to Ace.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@codecov
Copy link

codecov bot commented Mar 3, 2020

Codecov Report

Merging #4203 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4203      +/-   ##
==========================================
- Coverage   70.77%   70.77%   -0.01%     
==========================================
  Files         527      527              
  Lines       51464    51464              
  Branches     9656     9656              
==========================================
- Hits        36424    36423       -1     
- Misses      15040    15041       +1
Impacted Files Coverage Δ
lib/ace/range.js 84.82% <0%> (-0.69%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ee4c123...38f17f4. Read the comment docs.

@nightwing
Copy link
Member

There are two issues with the theme: selection and active line colors are same, so it is not possible to see single line selections, comments are not visible over selection.

@ghost
Copy link
Author

ghost commented Mar 7, 2020

Fixed. Should be okay to merge now

EDIT: Seems like comments are still not visible over a selection. :/

@nightwing
Copy link
Member

I found we had a workaround for themes that set same color to selection and highlight, could you please check if after my changes theme looks correct, or if we should make some other changes?

@ghost
Copy link
Author

ghost commented Mar 8, 2020

Made gutter color match Sublime, LGTM :shipit:

@nightwing
Copy link
Member

Thanks!

@nightwing nightwing merged commit 9115b68 into ajaxorg:master Mar 8, 2020
@ghost ghost deleted the patch-1 branch March 14, 2020 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant