-
Notifications
You must be signed in to change notification settings - Fork 5.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Nord theme (https://www.nordtheme.com/) #4203
Conversation
Codecov Report
@@ Coverage Diff @@
## master #4203 +/- ##
==========================================
- Coverage 70.77% 70.77% -0.01%
==========================================
Files 527 527
Lines 51464 51464
Branches 9656 9656
==========================================
- Hits 36424 36423 -1
- Misses 15040 15041 +1
Continue to review full report at Codecov.
|
There are two issues with the theme: selection and active line colors are same, so it is not possible to see single line selections, comments are not visible over selection. |
Fixed. Should be okay to merge now EDIT: Seems like comments are still not visible over a selection. :/ |
I found we had a workaround for themes that set same color to selection and highlight, could you please check if after my changes theme looks correct, or if we should make some other changes? |
Made gutter color match Sublime, LGTM |
Thanks! |
Issue #, if available: #4202
Description of changes: Make the popular Nord theme available to Ace.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.