Fix incorrect heap size calculation #55
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ajalab
commented
Feb 11, 2025
| @@ -120,9 +118,8 @@ where | |||
| /// | |||
| /// Sampled suffix array data is stored in this index. | |||
| pub fn size(&self) -> usize { | |||
There was a problem hiding this comment.
Maybe the name of this method size is a bit vague. Should we name it heap_size like vers-vec?
There was a problem hiding this comment.
I'd be happy to see this change!
ajalab
added a commit
that referenced
this pull request
Feb 11, 2025
faassen
approved these changes
Feb 11, 2025
This was referenced Feb 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the incorrect heap size calculation in the FM-index implementations and suffix arrays, as reported in #54.