Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I do the following:
document the
search
method on theFMIndexBackend
traitmake the
len()
method public on theFMIndexBackend
trait as I think it may be useful to end-users.Introduce a
HeapSize
trait so we can get the heap size of an index genericallyIntroduce API tests that exercise the API through the traits, to make sure I got them right (it's easy to get into infinite recursion; only fixed once I refined the trait bounds for Character and Converter).
Remove the
SearchIndex
struct in favor using theFMIndexBackend
trait as discussed.