Builder #42
Merged
Builder #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ajalab
approved these changes
Jan 26, 2025
Note that there are still two issues left: * IdConverter isn't automated yet * The benchmarks can't work with the backend trait somehow.
Note that I couldn't get rid of the `size` field as `sais` uses IdConverter with very specific sizes. But now the builder should allocate the appropriate size for an id converter (the default) automatically, handling ajalab#25
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here's the builder as I describe it mostly in #40
I've created it as a PR for the
refactor-api-wrapperbranch but it doesn't really depend on it, and we should merge that branch before we do this (without builder in that case).If we decide to go for this I would expose the builder on the top level, and make
new()andcount_onlyconstructor methods crate-only, so that the builder is the only way to construct an index.[this is a recreation of the pull request against master]